Secondly, since you're presenting this as a portfolio entry, I have some open, honest feedback. I quickly reviewed the repository and there are some pretty major orange-red flags that would dissuade employers from reaching out. Some of them include:
- Lack of coherent repository structure. All files under src/ with no sense of modularity
- The commit messages are very poor. Messages like "cool" and "jump jump" and "perf" do not provide any context to anyone outside of yourself (and probably not even you will remember what those changes were days/weeks from now)
- There are magic numbers everywhere. The biggest offender I found was in shaders.ts
There are more but those are the top ones I saw from my quick review. Again this isn't meant to discourage you. I wanted to provide the feedback to help you be more successful with potential employers. Cheers!
Why not just send this as an email rather than poisoning the whole thread and dissuading people from being interested/looking more? It's not a very nice thing to do.
I bet there's probably a bunch of things that are worth looking at. Focus on that to get other people seeing the obvious talent of this person who is asking for help.
>rather than poisoning the whole thread and dissuading people from being interested/looking more?
I partially disagree, offering public advice on how to improve can start a conversation, get the aspects fixed, and give an opportunity for op to show his abilities and come out on top. Other people can also chime in or in my case, appreciate general advice and learn from it.
What dissuades me more is another poster in the thread getting more upvotes than op by saying, oh that's cool, check out my unrelated project.. and then having to dig to find replies related to the original post.
If you treat a person's livelihood like an academic code review in public, that's not a great way to start a conversation, it just attaches negative keywords to their job application. That ain't mentoring: it's sabotage.
Ya I predicted it will go on the front page and everybody will like it. Aside from that, getting to this point required hundreds of *correct* design decisions that require skill. The AI isn't going to produce this on its own. Go ahead and try.
Thanks! Your points are fair. I work very differently solo than when I am in a team, I can produce very detailed, fine-grained and scoped commits/PRs and I do so when I am in that situation. Doing it while I am working on a solo prototype would simply slow me down and my concern at that point is velocity, not code quality.
This repo specifically has been vibe-coded in its entirety. The LLM put those magic numbers there and I agree it's not an ideal situation, but I'm not the one reading them/making changes to the code so it doesn't matter that much. Initially it had produced a giant main.ts file and then I told it split it to files and that's what it did. Managing an LLM-based-repository and managing a human-friendly repository are two very different things.
I have another ~500 repos on GitHub, you should taken a look at a few humanly-written as well for the feedback to be accurate of my situation.
Secondly, since you're presenting this as a portfolio entry, I have some open, honest feedback. I quickly reviewed the repository and there are some pretty major orange-red flags that would dissuade employers from reaching out. Some of them include:
- Lack of coherent repository structure. All files under src/ with no sense of modularity
- The commit messages are very poor. Messages like "cool" and "jump jump" and "perf" do not provide any context to anyone outside of yourself (and probably not even you will remember what those changes were days/weeks from now)
- There are magic numbers everywhere. The biggest offender I found was in shaders.ts
There are more but those are the top ones I saw from my quick review. Again this isn't meant to discourage you. I wanted to provide the feedback to help you be more successful with potential employers. Cheers!